Page 3 of 4

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Mon Jan 10, 2022 9:41 pm
by lundman
OK that was entirely my bad, here's the PKG you really want.

strings -a /Library/Extensions/zfs.kext/Contents/MacOS/zfs|grep -i macos
zfs-macOS-2.1.99-103-g6dfb6ddcc9-dirty

OpenZFSonOsX-2.1.99-Catalina-10.15.pkg
(16 MiB) Downloaded 597 times

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Mon Jan 10, 2022 9:45 pm
by abc123
We could blame Apple for forcing you to have to notarise.

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Mon Jan 10, 2022 9:46 pm
by lundman
I swapped the switches -L and -l around, and ironically, I invented them for my script in the first place,
so I really should know better :)

Hmm this might no longer have the debug printfs, so lets hope I actually got it right this time.

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Mon Jan 10, 2022 10:55 pm
by abc123
Success!

Code: Select all
russell@macos-catalina ~> sysctl zfs.kext_version
zfs.kext_version: 2.1.99-103_g6dfb6ddcc9
russell@macos-catalina ~> sysctl kstat.zfs | grep "_impl:"
kstat.zfs.darwin.tunable.zfs_vdev_raidz_impl: cycle [fastest] original scalar sse2 ssse3
kstat.zfs.darwin.tunable.icp_gcm_impl: cycle [fastest] generic pclmulqdq
kstat.zfs.darwin.tunable.icp_aes_impl: cycle [fastest] generic x86_64 aesni
kstat.zfs.darwin.tunable.zfs_fletcher_4_impl: [fastest] scalar superscalar superscalar4 sse2 ssse3


Would you be able to do a Monterey build at some point or would you want and do a 2.1.1 release with this in?

Thanks.

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Mon Jan 10, 2022 11:03 pm
by lundman
I could spit out a Monterey build, but I think this Catalina build should work fine?
I do want to release a 2.1.1 - need to check what else needs to be fixed for it though.

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Mon Jan 10, 2022 11:18 pm
by abc123
Yes, it's installed correctly on a Monterey VM.

Is there anything interesting in ZOL 2.1.1 or 2.1.2 that would be worth pulling in?

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Tue Jan 11, 2022 5:04 pm
by lundman
That PKG should also have your arcstat - you can check it looks ok

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Tue Jan 11, 2022 9:43 pm
by abc123
Yes thanks, arcstat/arc_summary working now.

RE: avx (from GitHub), Doesn't look like it's there. Wasn't there an issue with getting the AVX assembler stuff to work on 1.9.4 and it wasn't enabled?

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Wed Jan 12, 2022 1:04 am
by lundman
1.9.4 never had AVX - openzfs added it after. I think it is not brought in as it needs to be checked over, make sure it doesn't trash the wrong Registers, since the
volatile registers are different between Linux and macOS.

Similarly, arm64 assembler also needs to be over.

Re: PSA encryption performance - 1.9.4 MUCH faster than 2.1.

PostPosted: Sun Feb 20, 2022 5:18 am
by zfs-learner
The encryption read/write performance is really poor on my m1 Mac. I'm eager to get this problem fixed. (The read speed is about 15 MB/s). When will the new patches been released?
Thanks!