disk corruption with 1.7.1 release

All your general support questions for OpenZFS on OS X.

disk corruption with 1.7.1 release

Postby jojo45 » Sat Mar 17, 2018 4:04 am

I was running MacOS Sierra with 1.6.1 with no problems.

Upon upgrading to 1.7.1, all of my vmdk vmware virtual disk images began to have problems with disk corruption.

VMware fusion offered to correct the errors with the file structure but the fix would not persist. Each time the VM was opened, there would be a problem with the on-disk structure errors.

Downgrading back to 1.6.1 fixed all these problems.

Has anyone experienced something similar?

The problem seems to happen after lots of writes to the vmdk file, as occurs when installing cumulative updates to a Windows installation (300MB + of writes).
jojo45
 
Posts: 18
Joined: Sat Apr 08, 2017 6:04 am

Re: disk corruption with 1.7.1 release

Postby abc123 » Sat Mar 17, 2018 5:44 am

I'm seeing this also. I wasn't seeing it when running from commit c87b67697d121e3537bcc5d031c8d77f37cbc5dd but since moving to the 1.7.1 tag I am now seeing it also.
abc123
 
Posts: 63
Joined: Mon Jan 30, 2017 11:46 pm

Re: disk corruption with 1.7.1 release

Postby abc123 » Sun Mar 18, 2018 4:32 am

Reverting back to c87b67697d121e3537bcc5d031c8d77f37cbc5dd from 1st Dec resolves the issue so something in a newer commit causes it. Interestingly it only appears to happen on 1 out of the 2 VMs I use regularly. The do have 2 different properties. The one that doesn't have the issue is case-sensitive and LZ4 compression. The one that has the problem is case-insensitive and ZLE compression.

I need to do more experimentation to see if I can narrow it down to case-insensitivity and/or ZLE and which commit possibly introduced it.

Are your VM datasets case-sensitive or not? What about the compression?
abc123
 
Posts: 63
Joined: Mon Jan 30, 2017 11:46 pm

Re: disk corruption with 1.7.1 release

Postby jojo45 » Sun Mar 18, 2018 5:24 am

Case insensitive. Compressed with LZ4.
jojo45
 
Posts: 18
Joined: Sat Apr 08, 2017 6:04 am

Re: disk corruption with 1.7.1 release

Postby abc123 » Sun Mar 18, 2018 9:13 am

For me it looks like the issue is with virtual disks which aren't pre-allocated. I've got some VMs where the disk is pre-allocated and they're OK but VMs where the images aren't pre-allocated have the issue.
abc123
 
Posts: 63
Joined: Mon Jan 30, 2017 11:46 pm

Re: disk corruption with 1.7.1 release

Postby jojo45 » Sun Mar 18, 2018 9:32 am

None of my VM images are pre-allocated, so that would be consistent with your experience.

I have filed a bug report on github.
jojo45
 
Posts: 18
Joined: Sat Apr 08, 2017 6:04 am

Re: disk corruption with 1.7.1 release

Postby The Ghost of Mikey » Sat Mar 24, 2018 12:26 am

I have filed a bug report on github.


Looks like the commit, which introduced the issue, is reverted now.
Will someone create a hotfix release (still on 1.7.0 cauz of this bug, since I host some non-preallocated vm images...)?

Or it it safe to install 1.7.1 using the installer, take the 1.7.1 sources, revert the problematic commit and make/make install? Or would this introduce dozens of other problems? Since I would like to go the normal path with official releases ...
The Ghost of Mikey
 
Posts: 17
Joined: Sat Mar 22, 2014 1:29 am

Re: disk corruption with 1.7.1 release

Postby abc123 » Sun Mar 25, 2018 9:57 am

1.7.1 sources with that commit reverted worked for me but 1.7.2 is nut now which has reverted the commit.
abc123
 
Posts: 63
Joined: Mon Jan 30, 2017 11:46 pm

Re: disk corruption with 1.7.1 release

Postby abc123 » Tue Apr 03, 2018 12:30 am

abc123 wrote:1.7.1 sources with that commit reverted worked for me but 1.7.2 is nut now which has reverted the commit.


1.7.2 has been released and has this commit reverted so probably just worth updating to that if you're not familiar with git and building from source.
abc123
 
Posts: 63
Joined: Mon Jan 30, 2017 11:46 pm


Return to General Help

Who is online

Users browsing this forum: Google [Bot] and 29 guests